Important

Okay
  Public Ticket #1572236
Non-standard implementation
Closed

Comments

  • Jeff started the conversation
    May 11, 2018 at 8:19pm

    Installing a Magento module should *never* require someone to FTP files up to the app/code/ folder, please stop this, it's very poor practice that is plaguing the community.  Magento uses composer, in which your implementation is in need of improvement... 

    • The Megamenu module cannot run without the Ves_All module, but it is not defined in the composer.json as a dependency
    • You need to update your composer.json files to include php ~7.1.0 (this is what Magento 2.2.x is suggested to run on)
    • Ves_All module: Why would you use a composer extra/map node to place your code into the app/code folder?  This was deprecated and is not something I want on my store.

    As developers of modules you should be aware of the standards of managing modules within Magento more than anyone.

  • Jeff replied
    May 11, 2018 at 8:22pm

    Also, you have files to be manually uploaded under pub/media/

    Again, not standard

  •  1,319
    Land of replied
    May 14, 2018 at 4:43am

    Hello Jeff,

    Have a nice day!

    Thanks you for your comment!

    We know that, however our current market system are selling files, and more people does not know the composer setup. For now for commercial  extensions we just require setup via FTP, for free extension was supported setup via composer as the extension:

    https://packagist.org/packages/venustheme/module-imageslider

    We are building new system to selling private key for commercial extension, then on future people can setup via composer, just download composer file then run require composer setup file to setup our extension.