Important

Okay
  Public Ticket #1432067
Bug report "disable dimension"
Closed

Comments

  • Jimmy Heibert started the conversation

    When working with "disable dimensions", I have noticed that disabling a menu item (<li>) doesn't work unless the "disable dimension" is set also for the menu (<ul>). See, for example, the code in app/code/Ves/Megamenu/view/frontend/templates/menu_top.phtml, lines 79 through 128, where the if statement on line 80, 100 and 114 wraps the logic for disabling/enabling individual menu items. This means that disabling a menu item below a certain limit won't work unless the menu itself is disabled below some non-zero limit (it could be set to, say, 1, which would never actually disable the menu, but still activate the if-statement).

    Also (as by the latest update, which added the ability to also disable above a certain limit), to be able to disable a menu item below a limit, the menu has to also be disabled below some non-zero limit, while if a menu item would be disabled above a limit, the menu has to also be disabled above some non-zero limit.

    Finally, the ability to disable a menu item above a limit hasn't been added to admin. I found the file that creates the fields in admin to be app/code/Ves/Megamenu/Helper/Editor.php, where on lines 265 through 269, the field to disable below a limit is added, but no field is added to disable above a limit. However, for the menu, I can see that the field is added (lines 198 through 208 in the file app/code/Ves/Megamenu/Block/Adminhtml/Menu/Edit/Form.php).


    Is the project available on GitHub? If so, I would gladly like to help in fixing the above issues.

    Thank you in advance

  •  1,315
    Land of replied

    Hello Jimmy,

    Have a nice day!

    I will try to check again on disable dimension above and disable dimensions bellow on local as you mean.

    For now we removed the disable dimension option for each menu item, we just use it on menu profile. To disable menu item for each screen size, you can use the bootstrap hidden class for custom css class for menu item as this: hidden-lg, hidden-md, hidden-sm, hidden-xs

    We dont manage module project on github. 

  • Jimmy Heibert replied

    Thank you!

  •  1,315
    Land of replied

    You are welcome!

    We will update new module version with some updating on tomorrow.